m-trieu commented on code in PR #32774:
URL: https://github.com/apache/beam/pull/32774#discussion_r1838563507
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/AbstractWindmillStream.java:
##########
@@ -317,10 +320,13 @@ public String backendWorkerToken() {
return backendWorkerToken;
}
+ @SuppressWarnings("GuardedBy")
@Override
public final void shutdown() {
- // Don't lock on "this" before poisoning the request observer as allow IO
to block shutdown.
+ // Don't lock on "this" before poisoning the request observer since
otherwise the observer may
+ // be blocking in send().
requestObserver.poison();
+ isShutdown = true;
Review Comment:
cleaneed up was supposed to stay within the sync block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
