rohdesamuel commented on a change in pull request #12702:
URL: https://github.com/apache/beam/pull/12702#discussion_r480307676
##########
File path: sdks/python/apache_beam/runners/interactive/background_caching_job.py
##########
@@ -87,11 +87,10 @@ def _should_end_condition_checker(self):
return any([l.is_triggered() for l in self._limiters])
def is_done(self):
- is_terminated = self._pipeline_result.state is PipelineState.DONE
+ is_terminated = self._pipeline_result.state in (
+ PipelineState.DONE, PipelineState.CANCELLED)
Review comment:
Yeah, it definitely looks like it should be. Maybe Codev is trying to do
something smarter like static analysis on the logic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
