bzablocki commented on code in PR #32400:
URL: https://github.com/apache/beam/pull/32400#discussion_r1840502671
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SempBasicAuthClientExecutor.java:
##########
@@ -81,6 +87,15 @@ class SempBasicAuthClientExecutor implements Serializable {
COOKIE_MANAGER_MAP.putIfAbsent(this.cookieManagerKey, new CookieManager());
Review Comment:
I'll change to `COOKIE_MANAGER_MAP.computeIfAbsent(this.cookieManagerKey,
CookieManager::new)`, thanks.
Regarding the unconditional growth - in theory yes, but in practice there
won't be indefinite number of different combinations of `baseUrls` and
`usernames` (`CookieManagerKey`s), so it won't grow beyond a few elements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
