damccorm commented on code in PR #32081:
URL: https://github.com/apache/beam/pull/32081#discussion_r1841033733


##########
sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/schemas/utils/AvroUtils.java:
##########
@@ -451,8 +484,7 @@ public static Field 
toBeamField(org.apache.avro.Schema.Field field) {
   public static org.apache.avro.Schema.Field toAvroField(Field field, String 
namespace) {
     org.apache.avro.Schema fieldSchema =
         getFieldSchema(field.getType(), field.getName(), namespace);
-    return new org.apache.avro.Schema.Field(
-        field.getName(), fieldSchema, field.getDescription(), (Object) null);
+    return new org.apache.avro.Schema.Field(field.getName(), fieldSchema, 
field.getDescription());

Review Comment:
   This seems to break 
https://github.com/apache/beam/actions/workflows/beam_PostCommit_Java_Avro_Versions.yml
   
   I think it is because in some older versions of avro, the constructor is 
different - 
https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/Schema.Field.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to