m-trieu commented on code in PR #32774:
URL: https://github.com/apache/beam/pull/32774#discussion_r1844356091
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/harness/FanOutStreamingEngineWorkerHarness.java:
##########
@@ -299,24 +303,39 @@ private synchronized void
consumeWindmillWorkerEndpoints(WindmillEndpoints newWi
}
/** Close the streams that are no longer valid asynchronously. */
- private void closeStreamsNotIn(WindmillEndpoints newWindmillEndpoints) {
+ @CanIgnoreReturnValue
+ private ImmutableList<CompletableFuture<Void>> closeStreamsNotIn(
+ WindmillEndpoints newWindmillEndpoints) {
StreamingEngineBackends currentBackends = backends.get();
- currentBackends.windmillStreams().entrySet().stream()
- .filter(
- connectionAndStream ->
-
!newWindmillEndpoints.windmillEndpoints().contains(connectionAndStream.getKey()))
- .forEach(
- entry ->
- windmillStreamManager.execute(
- () -> closeStreamSender(entry.getKey(),
entry.getValue())));
+ List<CompletableFuture<Void>> closeStreamFutures =
+ currentBackends.windmillStreams().entrySet().stream()
+ .filter(
+ connectionAndStream ->
+ !newWindmillEndpoints
+ .windmillEndpoints()
+ .contains(connectionAndStream.getKey()))
+ .map(
+ entry ->
+ CompletableFuture.runAsync(
+ () -> closeStreamSender(entry.getKey(),
entry.getValue()),
+ windmillStreamManager))
+ .collect(Collectors.toList());
Set<Endpoint> newGlobalDataEndpoints =
new HashSet<>(newWindmillEndpoints.globalDataEndpoints().values());
- currentBackends.globalDataStreams().values().stream()
- .filter(sender -> !newGlobalDataEndpoints.contains(sender.endpoint()))
- .forEach(
- sender ->
- windmillStreamManager.execute(() ->
closeStreamSender(sender.endpoint(), sender)));
+ List<CompletableFuture<Void>> closeGlobalDataStreamFutures =
+ currentBackends.globalDataStreams().values().stream()
+ .filter(sender ->
!newGlobalDataEndpoints.contains(sender.endpoint()))
+ .map(
+ sender ->
+ CompletableFuture.runAsync(
+ () -> closeStreamSender(sender.endpoint(), sender),
windmillStreamManager))
+ .collect(Collectors.toList());
+
+ return ImmutableList.<CompletableFuture<Void>>builder()
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
