mutianf commented on code in PR #33001:
URL: https://github.com/apache/beam/pull/33001#discussion_r1847069694
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/changestreams/dao/BigtableChangeStreamAccessor.java:
##########
@@ -52,6 +52,7 @@ public class BigtableChangeStreamAccessor implements
AutoCloseable {
// Create one bigtable data/admin client per bigtable config
(project/instance/table/app profile)
private static final ConcurrentHashMap<BigtableConfig,
BigtableChangeStreamAccessor>
bigtableAccessors = new ConcurrentHashMap<>();
+ private static Duration readChangeStreamTimeout = Duration.ofSeconds(15);
Review Comment:
should this be null? DEFAULT_READ_CHANGE_STREAM_TIMEOUT already defines
the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]