jacobtomlinson commented on code in PR #32941:
URL: https://github.com/apache/beam/pull/32941#discussion_r1846191039
##########
sdks/python/apache_beam/runners/dask/dask_runner.py:
##########
@@ -99,8 +108,16 @@ def wait_until_finish(self, duration=None) -> str:
if duration is not None:
# Convert milliseconds to seconds
duration /= 1000
- self.client.wait_for_workers(timeout=duration)
- self.client.gather(self.futures, errors='raise')
+ for _ in ddist.as_completed(self.futures,
+ timeout=duration,
+ with_results=True):
+ # without gathering results, worker errors are not raised on the
client:
+ #
https://distributed.dask.org/en/stable/resilience.html#user-code-failures
+ # so we want to gather results to raise errors client-side, but we do
+ # not actually need to use the results here, so we just pass. to
gather,
+ # we use the iterative `as_completed(..., with_results=True)`, instead
+ # of aggregate `client.gather`, to minimize memory footprint of
results.
+ pass
Review Comment:
Good to know. Sounds like `as_completed` is the way then!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
