Polber commented on code in PR #33124:
URL: https://github.com/apache/beam/pull/33124#discussion_r1850877123
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcReadSchemaTransformProvider.java:
##########
@@ -241,7 +368,7 @@ public abstract static class Builder {
public abstract Builder setConnectionInitSql(List<String> value);
- public abstract Builder setFetchSize(Short value);
+ public abstract Builder setFetchSize(Integer value);
Review Comment:
The fetchSize on JdbcIO accepts Integer values, so this provider was cutting
out a large range of acceptable values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
