Abacn commented on code in PR #33173:
URL: https://github.com/apache/beam/pull/33173#discussion_r1852272176
##########
runners/google-cloud-dataflow-java/build.gradle:
##########
@@ -273,6 +273,87 @@ def createRunnerV2ValidatesRunnerTest = { Map args ->
}
}
+tasks.register('googleCloudPlatformRunnerV2DistrolessIntegrationTest',
Test.class) {
+ group = "verification"
+ dependsOn 'buildAndPushDistrolessContainerImage'
+ def javaVer = project.findProperty('testJavaVersion')
+ def repository = "us.gcr.io/apache-beam-testing/${System.getenv('USER')}"
+ def tag = project.findProperty('dockerTag')
+ def imageURL = "${repository}/beam_${javaVer}_sdk_distroless:${tag}"
+ def pipelineOptions = [
+ "--runner=TestDataflowRunner",
+ "--project=${gcpProject}",
+ "--region=${gcpRegion}",
+ "--tempRoot=${dataflowValidatesTempRoot}",
+ "--sdkContainerImage=${imageURL}",
+ "--experiments=use_unified_worker,use_runner_v2",
+ "--firestoreDb=${firestoreDb}",
+ ]
+ systemProperty "beamTestPipelineOptions", JsonOutput.toJson(pipelineOptions)
+
+ include '**/*IT.class'
+ exclude '**/BigQueryIOStorageReadTableRowIT.class'
+ exclude '**/SpannerWriteIT.class'
+ exclude '**/*KmsKeyIT.class'
+ exclude '**/FhirIOReadIT.class'
+ exclude '**/DicomIOReadIT.class'
+ exclude '**/FhirIOWriteIT.class'
+ exclude '**/FhirIOLROIT.class'
+ exclude '**/FhirIOSearchIT.class'
+ exclude '**/FhirIOPatientEverythingIT.class'
+ // failing due to pane index not incrementing after Reshuffle:
+ // https://github.com/apache/beam/issues/28219
+ exclude '**/FileLoadsStreamingIT.class'
+
+ maxParallelForks 4
+ classpath = configurations.googleCloudPlatformIntegrationTest
+ testClassesDirs =
files(project(":sdks:java:io:google-cloud-platform").sourceSets.test.output.classesDirs)
+ useJUnit {
+ filter {
+ // Only needs to run on direct runner
+ excludeTestsMatching
'org.apache.beam.sdk.io.gcp.bigtable.BigtableWriteIT.testE2EBigtableWriteWithEmptyMutationFailures'
+ excludeTestsMatching
'org.apache.beam.sdk.io.gcp.bigtable.BigtableWriteIT.testE2EBigtableWriteWithEmptyRowFailures'
+ excludeTestsMatching
'org.apache.beam.sdk.io.gcp.bigtable.BigtableWriteIT.testE2EBigtableWriteWithInvalidTimestampFailures'
+ excludeTestsMatching
'org.apache.beam.sdk.io.gcp.bigtable.BigtableWriteIT.testE2EBigtableWriteWithOversizedQualifierFailures'
+ }
+ }
+}
+
+tasks.register('buildAndPushDistrolessContainerImage', Task.class) {
+ def allowed = ["java17", "java21"]
Review Comment:
does this mean java8/11 are excluded from distroless container?
##########
runners/google-cloud-dataflow-java/build.gradle:
##########
@@ -273,6 +273,87 @@ def createRunnerV2ValidatesRunnerTest = { Map args ->
}
}
+tasks.register('googleCloudPlatformRunnerV2DistrolessIntegrationTest',
Test.class) {
Review Comment:
DataflowRunnerV2 PostCommit test suite is a very expensive one (7h+
runtime), more expensive if run with multiple Java versions. How about running
on Dataflow Example test suite, which was also what ARM tests running on.
ref:
https://github.com/apache/beam/blob/master/.github/workflows/beam_PostCommit_Java_Examples_Dataflow_ARM.yml
https://github.com/apache/beam/blob/a06454a22084242b4fe089b570fd090810885885/runners/google-cloud-dataflow-java/arm/build.gradle#L128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
