liferoad commented on code in PR #33216:
URL: https://github.com/apache/beam/pull/33216#discussion_r1859242371


##########
sdks/python/tox.ini:
##########
@@ -410,8 +410,9 @@ deps =
     tensorflow>=2.12rc1,<2.13
     # Help pip resolve conflict with typing-extensions for old version of TF 
https://github.com/apache/beam/issues/30852
     pydantic<2.7
-    protobuf==4.25.5
-extras = test,gcp,ml_test
+extras = test,gcp

Review Comment:
   Tox honors the package deps with this order: deps -> extras -> 
install_requires. So if tensorflow is set several times, only the last one 
takes the effect. @jrmccluskey FYI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to