Abacn commented on code in PR #33163:
URL: https://github.com/apache/beam/pull/33163#discussion_r1861124047
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -3625,7 +3622,8 @@ private <DestinationT> WriteResult expandTyped(
hasSchema,
"A schema must be provided if an avroFormatFunction "
+ "is set but no avroSchemaFactory is defined.");
- avroSchemaFactory = DEFAULT_AVRO_SCHEMA_FACTORY;
+ avroSchemaFactory =
+ (tableSchema) ->
BigQueryUtils.toGenericAvroSchema(tableSchema, true);
Review Comment:
aren't these no-op?
BigQueryAvroUtils.toGenericAvroSchema(schema) calls
BigQueryAvroUtils.toGenericAvroSchema(schema, true) calls
BigQueryAvroUtils.toGenericAvroSchema("root", schema, true, namespace)
BigQueryUtils.toGenericAvroSchema(schema, true) calls
BigQueryAvroUtils.toGenericAvroSchema("root", schema, true, namespace)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
