damondouglas commented on code in PR #33245:
URL: https://github.com/apache/beam/pull/33245#discussion_r1864755263
##########
.github/workflows/beam_PostCommit_Java_ValidatesDistrolessContainer_Dataflow.yml:
##########
@@ -88,10 +88,17 @@ jobs:
gcloud auth configure-docker us.gcr.io --quiet
gcloud auth configure-docker gcr.io --quiet
gcloud auth configure-docker us-central1-docker.pkg.dev --quiet
- - name: run validatesDistrolessContainer script
+ - name: run validatesDistrolessContainer script (Java 17)
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command:
:runners:google-cloud-dataflow-java:examplesJavaRunnerV2IntegrationTestDistroless
+ arguments: '-PtestJavaVersion=java17 -PdockerTag=$(date +%s)'
Review Comment:
The distroless Dockerfile doesn't really care about Java. That Gradle
property is needed to assign FROM using the referenced Beam Java SDK container
image. Whatever anyone who designs or changes that original image, the
distroless Dockerfile doesn't care.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
