robertwb commented on code in PR #33273:
URL: https://github.com/apache/beam/pull/33273#discussion_r1868532087
##########
sdks/python/apache_beam/yaml/yaml_join.py:
##########
@@ -62,9 +62,12 @@ def _validate_equalities(equalities, pcolls):
error_prefix = f'Invalid value "{equalities}" for "equalities".'
valid_cols = {
- name: set(dict(pcoll.element_type._fields).keys())
+ name: set(
+ dict(fields).keys() if fields and all(
+ isinstance(field, tuple) for field in fields) else fields)
for name,
pcoll in pcolls.items()
Review Comment:
Until yapf fixes its bug, put ()'s around (name, pcoll) to get better
wrapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
