ahmedabu98 commented on code in PR #33288:
URL: https://github.com/apache/beam/pull/33288#discussion_r1870574043
##########
sdks/python/apache_beam/io/jdbc.py:
##########
@@ -128,11 +128,11 @@ def default_io_expansion_service(classpath=None):
('disable_autocommit', typing.Optional[bool]),
('output_parallelization', typing.Optional[bool]),
('autosharding', typing.Optional[bool]),
+ ('write_batch_size', typing.Optional[np.int64]),
('partition_column', typing.Optional[str]),
('partitions', typing.Optional[np.int16]),
('max_connections', typing.Optional[np.int16]),
- ('driver_jars', typing.Optional[str]),
- ('write_batch_size', typing.Optional[np.int64])],
Review Comment:
Can we move the ordering in the Java SchemaTransform instead?
I'm thinking some users may be passing args to WriteToJdbc() relying on
ordering. Putting write_batch_size in the middle may break them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
