Abacn commented on code in PR #32402:
URL: https://github.com/apache/beam/pull/32402#discussion_r1872390431


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -668,6 +669,10 @@ public static void main(String[] args) throws Exception {
       enableBigQueryMetrics();
     }
 
+    if (DataflowRunner.hasExperiment(options, "enable_kafka_metrics")) {
+      KafkaSinkMetrics.setSupportKafkaMetrics(true);

Review Comment:
   Instead of setting IO flags in worker, one can utilize the 
JvmInitializer.runBeforeProcessing mechanism that is introduce a JvmInitializer 
implementation in org.apache.beam.sdk.io.kafka to initialize the flags on 
worker. This avoids the need of kafka dependency



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to