Abacn commented on code in PR #33221:
URL: https://github.com/apache/beam/pull/33221#discussion_r1873553019
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryAvroUtilsTest.java:
##########
@@ -501,48 +813,4 @@ public void testSchemaCollisionsInAvroConversion() {
String output = BigQueryAvroUtils.toGenericAvroSchema(schema,
false).toString();
assertThat(output.length(), greaterThan(0));
}
-
- /** Pojo class used as the record type in tests. */
- @SuppressWarnings("unused") // Used by Avro reflection.
- static class Bird {
Review Comment:
BigQueryAvroUtilsTest has been largely rewritten. Would you mind sharing the
idea behind the newly formed tests.
Also, this POJO class is removed and I do not see a replacement in new
tests. Are the related path (getSchema from POJO) still covered by tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
