lostluck opened a new pull request, #33334:
URL: https://github.com/apache/beam/pull/33334
Coder Contexts are largely deprecated as a notion in Beam, and aren't used,
with the default being the "nested" coder context instead of the Outer context.
There are a few places though that still set "outer coder context" by default,
notably in the CoderUtils helper methods.
Where this manifests for TestStream is that CoderUtils is used to take
elements and convert them into byte buffers when moved portably. While *most*
coders now ignore the difference, for various legacy reasons, the KVCoder still
pipes the context to the *value* coder, and some coders still understand and
use the difference. In this case, the StringUTF8 coder, when given the Outer
context, doesn't length prefix the string.
This leads to TestStream values being encoded in weird ways, that don't
translate portably. eg. If the values are KV<String, String> the Key will be
length prefixed, but the value will not be. This will ultimately cause a break
at test run time, because the CoderUtils path isn't used in decoding over Beam
Portability, but the normal decoder path, which wouldn't provide the Outer
context.
This is likely what's caused difficulty in using TestStream in non-Java SDKs.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
