TheNeuralBit commented on pull request #9779: URL: https://github.com/apache/beam/pull/9779#issuecomment-684965186
That's great thank you @zeidoo! What is the extent of our use of Avro in core Beam? Is it just AvroCoder and AvroSchema? That does seem to be the case based on the changes in this PR. I think AvroCoder is used pretty commonly so if we move it out of core we should add something to CHANGES.md to make sure users know they'll need to add a new dependency. We may want to call the new extension avro-1.8 or similar so we can add a 1.9 option down the road. As far as getting the change reviewed - I think the best bet would actually be to go ahead and put up a PR, you can mark it as a WIP if you don't feel its ready. From there the CI infrastructure will be able to run the tests that need a GCP account. I suspect you're right about the JDBC test failing due to a local timezone issue, it's probably worth filing a JIRA for that so we can fix the test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
