liferoad commented on code in PR #33317:
URL: https://github.com/apache/beam/pull/33317#discussion_r1879165534
##########
sdks/python/apache_beam/runners/worker/channel_factory.py:
##########
@@ -23,8 +23,11 @@
class GRPCChannelFactory(grpc.StreamStreamClientInterceptor):
DEFAULT_OPTIONS = [
- ("grpc.keepalive_time_ms", 20000),
- ("grpc.keepalive_timeout_ms", 300000),
+ # Don't send keep-alive pings. They should be disabled by default but
+ # historically in some cases were still incorrectly sent.
Review Comment:
can we add this to CHANGES.md?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
