sjvanrossum commented on code in PR #32406:
URL: https://github.com/apache/beam/pull/32406#discussion_r1883734336
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SessionServiceFactory.java:
##########
@@ -75,6 +76,33 @@ public abstract class SessionServiceFactory implements
Serializable {
*/
public abstract SessionService create();
+ /**
+ * Do not override. This method is called in the {@link
+ *
org.apache.beam.sdk.io.solace.SolaceIO.Read#expand(org.apache.beam.sdk.values.PBegin)}
method
+ * to set the Queue reference based on {@link
+ * org.apache.beam.sdk.io.solace.SolaceIO.Read#from(Solace.Queue)} or {@link
+ * org.apache.beam.sdk.io.solace.SolaceIO.Read#from(Solace.Topic)}. The
queue can be retrieved in
+ * the classes that inherit {@link SessionServiceFactory} with the getter
method {@link
+ * SessionServiceFactory#getQueue()}
+ */
+ public final void setQueue(Queue queue) {
+ this.queue = queue;
+ }
+
+ /**
+ * Getter for the queue. Do not override. This is nullable, because at the
construction time this
Review Comment:
Same here as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
