damccorm commented on code in PR #32289: URL: https://github.com/apache/beam/pull/32289#discussion_r1884191877
########## sdks/python/apache_beam/io/gcp/bigquery_tools.py: ########## @@ -352,7 +352,12 @@ class BigQueryWrapper(object): HISTOGRAM_METRIC_LOGGER = MetricLogger() - def __init__(self, client=None, temp_dataset_id=None, temp_table_ref=None): + def __init__( + self, + client=None, + temp_dataset_id=None, + temp_table_ref=None, + project_id=None): Review Comment: I don't think it is actually getting assigned, though, and other functions take in project_id as parameters. If it is passed in to initialize the object, I think it will be ignored as written -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
