tvalentyn commented on code in PR #32600: URL: https://github.com/apache/beam/pull/32600#discussion_r1892946323
########## sdks/python/apache_beam/runners/worker/statesampler_interface.py: ########## @@ -0,0 +1,24 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +from abc import ABC, abstractmethod + + +class StateSamplerInterface(ABC): + @abstractmethod + def update_metric(self, typed_metric_name, value): Review Comment: Discussed with @robertwb offline - cdef Cython classes cannot inherit from python classes, there is a limited support for multiple inheritance but comes with a potential performance hit, and this is performance sensitive code; we can leave the cython codepath alone and add a comment about the existence of the StateSampler interfaces defined in python codebase but not use them in Cythonized codepath. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
