twosom commented on code in PR #33212:
URL: https://github.com/apache/beam/pull/33212#discussion_r1894007388
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/state/FlinkStateInternals.java:
##########
@@ -571,6 +573,27 @@ public void clear() {
throw new RuntimeException("Error clearing state.", e);
}
}
+
+ @Override
+ public boolean equals(@Nullable Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+
+ final FlinkOrderedListState<?> that = (FlinkOrderedListState<?>) o;
+
+ return namespace.equals(that.namespace) && stateId.equals(that.stateId);
+ }
+
+ @Override
+ public int hashCode() {
+ int result = namespace.hashCode();
Review Comment:
@kennknowles
The current implementation follows the same hashCode semantics used in
FlinkStateInternals. I'm a bit unclear whether suggesting `Objects.hashCode`
means we should replace the current implementation, or if you're suggesting
that overriding `hashCode` is unnecessary altogether.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
