razvanculea commented on code in PR #32805:
URL: https://github.com/apache/beam/pull/32805#discussion_r1898591260
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiLoads.java:
##########
@@ -354,25 +355,34 @@ public WriteResult expandUntriggered(
rowUpdateFn,
badRecordRouter));
+ PCollection<KV<DestinationT, StorageApiWritePayload>>
successfulConvertedRows =
+ convertMessagesResult.get(successfulConvertedRowsTag);
+
+ if (numShards > 0) {
Review Comment:
With this PR, those that might unknowingly set this shard param in batch,
will see a change (because there will be redistribute that matches the number
of shards set), and this change should impact the result of the jobs (they will
still succeed) .
There will an extra step and the batch will be consistent with the job graph
in streaming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
