lostluck commented on PR #33236: URL: https://github.com/apache/beam/pull/33236#issuecomment-2563977256
@LeoCBS Thanks for your patience over this holiday season. 1. That looks about right! 2. There's no need to put the enabling function in the `harnessopts` package. The harness options were split up for package privacy reasons. Due to how tightly bound this feature is to GCS, please keep enabling function in the GCS filesystem package. 3. Pipelines that would need to have that set will need to call it in the before pipeline submission in the binary's 'main'. It must be before pipeline submission, but doesn't have to be before beam.Init. Note that whatever is doing the call for this *is* allowed to use whatever environment variable you like. You can automate it that way if that's how you prefer. (eg. A final user specific package to call it at package init time, that looks for your environment variable, and then calls the enabler method.) (or as you suggest, a flag, that gets set by the binary, and then is used when calling the enabling function). 4. You can add a test in the GCS filesystem package, that calls hooks.RunInitHooks -> https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/util/hooks/hooks.go#L115 That will execute the enabled hooks. You should be able to verify that the billingProject package variable was set as expected there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
