damondouglas commented on code in PR #33453: URL: https://github.com/apache/beam/pull/33453#discussion_r1899727112
########## sdks/python/apache_beam/runners/worker/sdk_worker.py: ########## @@ -893,13 +893,14 @@ class GrpcStateHandlerFactory(StateHandlerFactory): Caches the created channels by ``state descriptor url``. """ - def __init__(self, state_cache, credentials=None): - # type: (StateCache, Optional[grpc.ChannelCredentials]) -> None + def __init__(self, state_cache, worker_id, credentials=None): + # type: (StateCache, Optional[str], Optional[grpc.ChannelCredentials]) -> None Review Comment: The least obtrusive approach. There are many places in the code that instantiate without the workerid. This PR adds the minimal needed to get prism working. I wanted to be very careful what I changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
