kennknowles commented on PR #33472: URL: https://github.com/apache/beam/pull/33472#issuecomment-2568160361
> > This matches the fix I had to do in some other places. Did it work for this jar? Perhaps we should make it default somehow... I don't know if there is a downside. > > yeah I made it default to expansion services, where technically is run on different jre environment, and directly (without dependency resolution like maven or gradle) > > Did a little search it seems multi-release jar is a debated, e.g. this blog https://blog.gradle.org/mrjars . So I ended up with only enabling it if upstream dependencies has used multi-released jar > > imo the issue itself kind of indicated multi-release jar can bring problems. Good point. And thanks for the link to that article. It does seem like this could have the same impact on Beam users who build uberjars. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
