kennknowles commented on code in PR #33418:
URL: https://github.com/apache/beam/pull/33418#discussion_r1901210759
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/SdkHarnessOptions.java:
##########
@@ -110,6 +110,13 @@ enum LogLevel {
void setLogMdc(boolean value);
+ /** This option controls whether logging will be redirected through the
FnApi. */
+ @Description("Controls whether logging will be redirected through the
FnApi.")
+ @Default.Boolean(true)
Review Comment:
And probably a comment that is very expressly "in normal usage, setting this
to a non-default value will cause logs to be dropped"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
