damondouglas commented on code in PR #33438:
URL: https://github.com/apache/beam/pull/33438#discussion_r1901250102
##########
sdks/go/pkg/beam/runners/prism/internal/execute.go:
##########
@@ -86,33 +87,6 @@ func RunPipeline(j *jobservices.Job) {
j.Done()
}
-// makeWorker creates a worker for that environment.
-func makeWorker(env string, j *jobservices.Job) (*worker.W, error) {
- wk := worker.New(j.String()+"_"+env, env)
-
- wk.EnvPb = j.Pipeline.GetComponents().GetEnvironments()[env]
- wk.PipelineOptions = j.PipelineOptions()
- wk.JobKey = j.JobKey()
- wk.ArtifactEndpoint = j.ArtifactEndpoint()
-
- go wk.Serve()
-
- if err := runEnvironment(j.RootCtx, j, env, wk); err != nil {
- return nil, fmt.Errorf("failed to start environment %v for job
%v: %w", env, j, err)
- }
- // Check for connection succeeding after we've created the environment
successfully.
- timeout := 1 * time.Minute
- time.AfterFunc(timeout, func() {
- if wk.Connected() || wk.Stopped() {
- return
- }
- err := fmt.Errorf("prism %v didn't get control connection to %v
after %v", wk, wk.Endpoint(), timeout)
- j.Failed(err)
- j.CancelFn(err)
- })
Review Comment:
I added this back. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
