Abacn commented on code in PR #33511:
URL: https://github.com/apache/beam/pull/33511#discussion_r1905908615
##########
sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/catalog/IcebergCatalogBaseIT.java:
##########
@@ -315,7 +319,9 @@ private List<Record> readRecords(Table table) {
return writtenRecords;
}
- @Test
+ private static final int FIVE_MINUTES_IN_MS = 5 * 60 * 1000;
+
+ @Test(timeout = FIVE_MINUTES_IN_MS)
Review Comment:
We can use a `@Rule` to set timeout for all tests, which has a smaller diff:
```
@Rule public transient Timeout globalTimeout = Timeout.seconds(300);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
