chamikaramj commented on code in PR #33511:
URL: https://github.com/apache/beam/pull/33511#discussion_r1907602871
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -797,6 +798,7 @@ class BeamModulePlugin implements Plugin<Project> {
hamcrest :
"org.hamcrest:hamcrest:$hamcrest_version",
http_client :
"org.apache.httpcomponents:httpclient:$httpclient_version",
http_core :
"org.apache.httpcomponents:httpcore:$httpcore_version",
+ iceberg_bqms_catalog :
"https://storage.googleapis.com/spark-lib/bigquery/iceberg-bigquery-catalog-${iceberg_bqms_catalog_version}.jar";,
Review Comment:
Can we move this logic to the specific module and just keep the constant
here ? At least let's add a TODO here to update when the jar is released to a
Maven repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
