ahmedabu98 commented on code in PR #33579:
URL: https://github.com/apache/beam/pull/33579#discussion_r1915390523
##########
sdks/python/apache_beam/yaml/yaml_io.py:
##########
@@ -484,6 +484,91 @@ def attributes_extractor(row):
timestamp_attribute=timestamp_attribute))
+def read_from_iceberg(
+ table: str,
+ catalog_name: Optional[str] = None,
+ catalog_properties: Optional[Mapping[str, str]] = None,
+ config_properties: Optional[Mapping[str, str]] = None,
+):
+ # TODO(robertwb): It'd be nice to derive these from the iceberg (or managed)
+ # scheams.
Review Comment:
would be good to populate the parameters programmatically too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
