arunpandianp commented on PR #33581: URL: https://github.com/apache/beam/pull/33581#issuecomment-2591454385
> I was thinking that since java protos are immutable that this would be cheap. But it may not cache the size internally so seems ok to change. > > Do you have any #s from testing/profiles to add to description as motivation? added a profile screenshot. The results are cached internally https://stackoverflow.com/a/1903792. But it was getting called in the Getwork loop for the first time and calculating size for all workitems in a single thread seems costly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
