bitnahian opened a new pull request, #33598:
URL: https://github.com/apache/beam/pull/33598
# Addresses #20219
- Introduces `withResults()` API to `DatastoreV1.Write`,
`DatastoreV1.DeleteEntity` and `DatastoreV1.DeleteKey` PTransforms, which
returns `PCollection<DatastoreV1.WriteSuccessSummary>` instead of `PDone`.
- Allows Wait.on semantics for DatastoreIO, e.g.
```
PCollection<Entity> firstBatch = ... ;
PCollection<Entity> secondBatch = ... ;
PCollection<DatastoreV1.WriteSuccessSummary> firstWriteResults =
firstBatch.apply(DatastoreIO.v1().write().withProjectId(project).withResults());
secondBatch
.apply(Wait.on(firstWriteResults)) // Allows Wait.on
.setCoder(secondBatch.getCoder())
.apply(DatastoreIO.v1().write().withProjectId(project)); // Returns
PDone without withResults()
```
- Maintains backward compatibility with existing API structure
- Draws inspiration from JdbcIO and FirestoreIO connectors
- Modifies unit tests to mock datastore stub to return CommitResponses
- Introduces new integration tests to test the `withResults()` API
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
