lostluck commented on PR #33434: URL: https://github.com/apache/beam/pull/33434#issuecomment-2597098235
Going to revert this, as it's causing unanticipated issues with the import to Google, where it was to have more of a benefit. 1. It turns out that we would need to migrate to "editions" first, at least to 2023, in order to change the proto files properly, when moving to other code. That increases the scope to all Java and Python code as well, as a result (though in principle it's just a proto file change, not a generated code change See https://protobuf.dev/editions/overview/) 2. Some of the conversions seem to have been missed somehow, leading to a scattering of build errors. Some of the changes can be maintained, but will be re-added separately (such as improvements to the proto generator file, and a more prudent migration to edition=2023). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
