robertwb commented on code in PR #33613:
URL: https://github.com/apache/beam/pull/33613#discussion_r1919398123
##########
sdks/python/apache_beam/yaml/integration_tests.py:
##########
@@ -124,7 +124,10 @@ def provider_sets(spec, require_available=False):
for p in spec['pipelines']))
def filter_to_available(t, providers):
- if require_available:
+ if t == 'LogForTesting':
+ # Don't fan out to all the (many) possibilities for this one...
+ return [p for p in providers if isinstance(p,
yaml_provider.InlineProvider)]
Review Comment:
This would still double the number of tests we need (and make the number of
tests change based on whether one added logging) I'm going to leave it as is
(though I like the idea of explicitly limiting to 1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
