kennknowles commented on code in PR #33540:
URL: https://github.com/apache/beam/pull/33540#discussion_r1922744033
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java:
##########
@@ -368,8 +368,13 @@ public synchronized BigQueryStorageStreamSource<T>
getCurrentSource() {
.setName(source.readStream.getName())
.setFraction((float) fraction)
.build();
-
- SplitReadStreamResponse splitResponse =
storageClient.splitReadStream(splitRequest);
+ SplitReadStreamResponse splitResponse;
+ try {
+ splitResponse = storageClient.splitReadStream(splitRequest);
+ } catch (Exception e) {
Review Comment:
Generalization question: is this a pattern that the runner should use all
the time? (so the worker should wrap calls to `splitAtFraction` and survive any
error and just process without splitting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
