kennknowles commented on code in PR #33419:
URL: https://github.com/apache/beam/pull/33419#discussion_r1922800426
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/fn/stream/DirectStreamObserver.java:
##########
@@ -69,7 +69,7 @@ public DirectStreamObserver(Phaser phaser,
CallStreamObserver<T> outboundObserve
@Override
public void onNext(T value) {
synchronized (lock) {
- if (++numMessages >= maxMessagesBeforeCheck) {
+ if (++numMessages > maxMessagesBeforeCheck) {
Review Comment:
Curiously enough, my change moved it in the opposite direction: whereas
before there were 10 messages per check (as desired) now there are 10 for the
first and 11 for subsequent checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
