baeminbo commented on PR #33684: URL: https://github.com/apache/beam/pull/33684#issuecomment-2603628322
This fixes GCS upload errors are swallowed in `PrintWriter` at `DataflouwRunner.run()`. To test the fix, the unit tests mock the static method `FileSystems.create()` in `DataflowRunnerTest`. For this, `Mockito.mockStatic` is used instead of `PowerMockito.mockStatic` so that we don't need `PowerMockRunner` anymore for some unit tests that mock static methods. The dependency `mockito-core` was replaced by `mockito-inline` for the `Mockito.mockStatic` change. I changed `DataflowPipelineOptionsTest` as well to remove the usage of `PowerMockito.mockStatic`. I fixed some warnings such as unnecessary type conversion, unthrown exceptions, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
