lostluck commented on code in PR #33705:
URL: https://github.com/apache/beam/pull/33705#discussion_r1924490461
##########
sdks/go/pkg/beam/runners/prism/internal/environments.go:
##########
@@ -46,16 +47,26 @@ import (
func runEnvironment(ctx context.Context, j *jobservices.Job, env string, wk
*worker.W) error {
logger := j.Logger.With(slog.String("envID", wk.Env))
- // TODO fix broken abstraction.
- // We're starting a worker pool here, because that's the loopback
environment.
Review Comment:
Yeah, it's mostly referring to the "one environment, one worker" notion. The
"pool" for example could be several "w orkers" all in the same environment.
If we ever decide to make prism distributed and scalable, then this code
would need to change anyway, so the TODO is moot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
