scwhittle commented on code in PR #33688:
URL: https://github.com/apache/beam/pull/33688#discussion_r1925124367
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillStateCache.java:
##########
@@ -79,15 +79,18 @@ public class WindmillStateCache implements
StatusDataProvider {
WindmillStateCache(long sizeMb, boolean supportMapViaMultimap) {
this.workerCacheBytes = sizeMb * MEGABYTES;
+ int stateCacheConcurrencyLevel =
+ Math.max(STATE_CACHE_CONCURRENCY_LEVEL,
Runtime.getRuntime().availableProcessors());
this.stateCache =
CacheBuilder.newBuilder()
.maximumWeight(workerCacheBytes)
+ .weakValues()
Review Comment:
let's do the weak values separately with some more investigation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
