razvanculea commented on PR #33412: URL: https://github.com/apache/beam/pull/33412#issuecomment-2607439690
@Abacn , @RustedBones , the change from bytes[] to ByteBuffer broke the [BigQueryIOLT](https://github.com/apache/beam/blob/master/it/google-cloud-platform/src/test/java/org/apache/beam/it/gcp/bigquery/BigQueryIOLT.java).java for the STORAGE_WRITE_API tests. Should I also change the BigQueryIOLT to ByteBuffer to write ? (it's one line to change) What about users already writing the old way, bytes[] with STORAGE_WRITE_API ? To update to the newest SDK post this change they'll need to wrap their bytes[] into ByteBuffer. (this is right, but was not needed before) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
