ahmedabu98 commented on code in PR #33612: URL: https://github.com/apache/beam/pull/33612#discussion_r1927266191
########## sdks/python/apache_beam/io/fileio.py: ########## @@ -522,7 +522,7 @@ class WriteToFiles(beam.PTransform): # Too many files will add memory pressure to the worker, so we let it be 20. MAX_NUM_WRITERS_PER_BUNDLE = 20 - DEFAULT_SHARDING = 5 + DEFAULT_SHARDING = 1 Review Comment: Is this change necessary? I think line 570 can just check if the input `shards` is None instead of referring to `self.shards > 1` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
