damccorm commented on code in PR #33740:
URL: https://github.com/apache/beam/pull/33740#discussion_r1927475082
##########
sdks/python/test-suites/tox/py39/build.gradle:
##########
@@ -154,17 +154,17 @@ test.dependsOn "testPy39tensorflow-212"
postCommitPyDep.dependsOn "testPy39tensorflow-212"
// Create a test task for each minor version of transformers
-toxTask "testPy39transformers-428", "py39-transformers-428", "${posargs}"
-test.dependsOn "testPy39transformers-428"
-postCommitPyDep.dependsOn "testPy39transformers-428"
+toxTask "testPy39transformers-445", "py39-transformers-445", "${posargs}"
+test.dependsOn "testPy39transformers-445"
+postCommitPyDep.dependsOn "testPy39transformers-445"
-toxTask "testPy39transformers-429", "py39-transformers-429", "${posargs}"
-test.dependsOn "testPy39transformers-429"
-postCommitPyDep.dependsOn "testPy39transformers-429"
+toxTask "testPy39transformers-446", "py39-transformers-446", "${posargs}"
+test.dependsOn "testPy39transformers-446"
+postCommitPyDep.dependsOn "testPy39transformers-446"
-toxTask "testPy39transformers-430", "py39-transformers-430", "${posargs}"
-test.dependsOn "testPy39transformers-430"
-postCommitPyDep.dependsOn "testPy39transformers-430"
+toxTask "testPy39transformers-447", "py39-transformers-447", "${posargs}"
+test.dependsOn "testPy39transformers-447"
+postCommitPyDep.dependsOn "testPy39transformers-447"
Review Comment:
Do you know what the underlying issue is with these dependencies? It would
be better to keep one of these as a lower bound if possible so that we are able
to test that beam is still compatible with lower versions of transformers. My
ideal would be to have 2 tests, one that is `testPy39transformers-428` to test
our lower bound and one that is `testPy39transformers-447` to test our upper
bound
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
