damccorm commented on code in PR #33743:
URL: https://github.com/apache/beam/pull/33743#discussion_r1928825852
##########
sdks/go/container/tools/logging.go:
##########
@@ -119,5 +119,9 @@ func (l *Logger) Errorf(ctx context.Context, format string,
args ...any) {
// Fatalf logs the message with Critical severity, and then calls os.Exit(1).
func (l *Logger) Fatalf(ctx context.Context, format string, args ...any) {
l.Log(ctx, fnpb.LogEntry_Severity_CRITICAL, fmt.Sprintf(format,
args...))
+ // Allow additional time for other background processes (e.g., log
agent) to
Review Comment:
Nit: Could we log something like: "Completing background processes before
exiting..." so that users understand the pause?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
