scwhittle commented on code in PR #33755:
URL: https://github.com/apache/beam/pull/33755#discussion_r1928952013
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/ActiveWorkState.java:
##########
@@ -302,22 +276,27 @@ synchronized void invalidateStuckCommits(
}
}
+ private static @Nullable Entry<WorkId, ExecutableWork> firstEntry(
Review Comment:
can this return Nullable ExecutableWork (maybe name firstValue then).
that itself contains the workid anyway if needed. and seems like it would
clean up where used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
