kennknowles commented on code in PR #33554:
URL: https://github.com/apache/beam/pull/33554#discussion_r1929024339
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/SerializableDataFile.java:
##########
@@ -199,4 +203,105 @@ DataFile createDataFile(Map<Integer, PartitionSpec>
partitionSpecs) {
}
return output;
}
+
+ @Override
+ public final boolean equals(@Nullable Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ SerializableDataFile that = (SerializableDataFile) o;
+ return getPath().equals(that.getPath())
+ && getFileFormat().equals(that.getFileFormat())
+ && getRecordCount() == that.getRecordCount()
+ && getFileSizeInBytes() == that.getFileSizeInBytes()
+ && getPartitionPath().equals(that.getPartitionPath())
+ && getPartitionSpecId() == that.getPartitionSpecId()
+ && Objects.equals(getKeyMetadata(), that.getKeyMetadata())
+ && Objects.equals(getSplitOffsets(), that.getSplitOffsets())
+ && Objects.equals(getColumnSizes(), that.getColumnSizes())
+ && Objects.equals(getValueCounts(), that.getValueCounts())
+ && Objects.equals(getNullValueCounts(), that.getNullValueCounts())
+ && Objects.equals(getNanValueCounts(), that.getNanValueCounts())
+ && mapEquals(getLowerBounds(), that.getLowerBounds())
+ && mapEquals(getUpperBounds(), that.getUpperBounds());
+ }
+
+ private static boolean mapEquals(
+ @Nullable Map<Integer, byte[]> map1, @Nullable Map<Integer, byte[]>
map2) {
+ if (map1 == null && map2 == null) {
+ return true;
+ } else if (map1 == null || map2 == null) {
+ return false;
+ }
+ Equivalence<byte[]> byteArrayEquivalence =
+ new Equivalence<byte[]>() {
+ @Override
+ protected boolean doEquivalent(byte[] a, byte[] b) {
+ return Arrays.equals(a, b);
+ }
+
+ @Override
+ protected int doHash(byte[] bytes) {
+ return Arrays.hashCode(bytes);
+ }
+ };
+
+ return Maps.difference(map1, map2, byteArrayEquivalence).areEqual();
+ }
+
+ @Override
+ public final int hashCode() {
+ int hashCode = 1;
Review Comment:
use `Objects.hashCode` I'd say
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
