jto commented on PR #32440: URL: https://github.com/apache/beam/pull/32440#issuecomment-2615206447
Hey @kennknowles ! Thanks for following up. I merged the latest changes from master and the PR can now be merged. I had to add another test to the sickbay. `org.apache.beam.sdk.transforms.ViewTest.testTriggeredLatestSingleton` makes both `validatesRunnerBatch` and `validatesRunnerBatchWithDataStream` fail with a timeout. Technically the test passes in both cases but for some reason it takes a very long time to execute. Because it causes the same issue with and without DataStream, I don't think this PR is the cause. Some of the Python tests are failing with the following exception: ``` ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject ``` which does not look like to be caused by this PR. `:sdks:java:harness:test` failed after ~6h which again looks unrelated to this PR. It'd be ideal if fixes were available and could be rebased into my branch to get all the tests green before merging but otherwise I think the changes in the Flink runner are in a good shape. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
