RustedBones commented on code in PR #33422:
URL: https://github.com/apache/beam/pull/33422#discussion_r1930244954
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/AvroGenericRecordToStorageApiProto.java:
##########
@@ -115,34 +120,97 @@ static String convertUUID(Object value) {
}
static Long convertTimestamp(Object value, boolean micros) {
- if (value instanceof ReadableInstant) {
- return ((ReadableInstant) value).getMillis() * (micros ? 1000 : 1);
+ if (value instanceof org.joda.time.ReadableInstant) {
Review Comment:
! don't think this is related. `joda-time` must be supported here as long as
avro `1.8` and `1.9` are supported by beam
[here](https://github.com/apache/beam/blob/3d651eb51ddda8ef71f190de39a4e1e43b1c20ea/sdks/java/extensions/avro/build.gradle#L40).
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/AvroGenericRecordToStorageApiProto.java:
##########
@@ -115,34 +120,97 @@ static String convertUUID(Object value) {
}
static Long convertTimestamp(Object value, boolean micros) {
- if (value instanceof ReadableInstant) {
- return ((ReadableInstant) value).getMillis() * (micros ? 1000 : 1);
+ if (value instanceof org.joda.time.ReadableInstant) {
Review Comment:
I don't think this is related. `joda-time` must be supported here as long as
avro `1.8` and `1.9` are supported by beam
[here](https://github.com/apache/beam/blob/3d651eb51ddda8ef71f190de39a4e1e43b1c20ea/sdks/java/extensions/avro/build.gradle#L40).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
