lostluck commented on PR #33763: URL: https://github.com/apache/beam/pull/33763#issuecomment-2616688840
RFAL We have a disagreement on the design (single stateful isReady vs splitting it into onElement, shouldFire, onFire, like Java does). I'm not convinced there's a material benefit to the split in regards to readability or testability. You get extremely fine grain unit tests, but what happens within a sequence of elements for a given watermark is what matters. What I'm looking for is a reason for them to be separate. eg. Without the individual methods, we can't evaluate X, which would need shouldFire + onFire, but never onElement. It is possible that the necessity of a split will become obviously required -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
